Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid photutils 1.2.0 #6378

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Avoid photutils 1.2.0 #6378

merged 2 commits into from
Oct 6, 2021

Conversation

jdavies-st
Copy link
Collaborator

Description

This PR addresses the incompatibility of jwst 1.3.2 with photutils 1.2.0. This patches the 1.3.* release series to avoid this version of photutils.

Compatibility with photutils 1.2.0 is already addressed on jwst master and will be included in a jwst 1.4.0 release.

Checklist

  • Tests
  • Documentation
  • Change log
  • Milestone
  • Label(s)

@jdavies-st jdavies-st added this to the Build 7.8.2 milestone Oct 5, 2021
@jdavies-st jdavies-st requested a review from hbushouse October 5, 2021 16:41
@codecov
Copy link

codecov bot commented Oct 5, 2021 •
edited
Loading

Codecov Report

Merging #6378 (ac5aeae) into 1.3.x (1e20478) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##            1.3.x    #6378      +/-   ##
==========================================
+ Coverage   78.08%   78.16%   +0.08%     
==========================================
  Files         405      405              
  Lines       35991    35991              
==========================================
+ Hits        28102    28134      +32     
+ Misses       7889     7857      -32
Flag Coverage Δ *Carryforward flag
nightly 78.08% <ø> (ø) Carriedforward from e21623b
unit 58.53% <ø> (+0.39%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
jwst/associations/lib/constraint.py 93.65% <0.00%> (+0.37%) ⬆️
jwst/wiimatch/match.py 67.30% <0.00%> (+1.92%) ⬆️
jwst/wiimatch/lsq_optimizer.py 88.42% <0.00%> (+5.26%) ⬆️
jwst/wiimatch/utils.py 83.33% <0.00%> (+16.66%) ⬆️
jwst/lib/catalog_utils.py 94.73% <0.00%> (+47.36%) ⬆️
jwst/model_blender/textutil.py 100.00% <0.00%> (+80.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e20478...ac5aeae. Read the comment docs.

@jdavies-st
Copy link
Collaborator Author

jdavies-st commented Oct 5, 2021 •
edited
Loading

Also pulled in the fixes to the doc build already implemented on master via #6230 in order to get the documentation build working.

hbushouse
hbushouse approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Once it's merged we should make a fairly general announcement via the usual channels to make sure users know about this and how to use it to avoid problems.

@jdavies-st jdavies-st merged commit 4cfc1f6 into spacetelescope:1.3.x Oct 6, 2021
@jdavies-st jdavies-st deleted the pin-photutils branch October 6, 2021 13:47
@nden nden mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbushouse hbushouse hbushouse approved these changes

Assignees
No one assigned
Labels
documentation infrastructure installation
Projects
None yet
Milestone
Build 7.8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jdavies-st @hbushouse